#RI-4815 get a portion of the string (FE) #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irinaAbramova-dev
requested review from
zalenskiSofteq and
romansergeenkosofteq
irinaAbramova-dev
changed the title
irinaAbramova-dev
removed request for
zalenskiSofteq and
romansergeenkosofteq
…I-4815-portion-of-string
…I-4815-portion-of-string
irinaAbramova-dev
requested review from
zalenskiSofteq and
romansergeenkosofteq
irinaAbramova-dev
changed the title
...i/src/pages/browser/components/key-details-header/components/Formatter/KeyValueFormatter.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/browser/components/key-details-header/KeyDetailsHeader.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/browser/components/string-details/StringDetails.spec.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
October 17, 2023 19:02
…815-portion-of-string
…815-portion-of-string
| @@ -142,77 +161,141 @@ const StringDetails = (props: Props) => { | |||
|
|
|||
| const isLoading = loading || value === null | |||
|
|
|||
| const handleLoadAll = async (key: RedisResponseBuffer, type: KeyTypes | ModulesKeyTypes) => { | |||
| const endString = length - 1 | |||
| await onRefresh(key, type, { end: endString }) | |||
There was a problem hiding this comment.
do we need to wait when refresh is finished to send telemetry? I think we don't
| }) | ||
| } | ||
|
|
||
| const handleDownloadString = async (e: React.MouseEvent<HTMLAnchorElement>) => { |
There was a problem hiding this comment.
don't need to make this function as async
irinaAbramova-dev
requested review from
zalenskiSofteq and
romansergeenkosofteq
zalenskiSofteq
approved these changes
Oct 18, 2023
irinaAbramova-dev
merged commit 49c04bb
into
feature/RI-4815-portion-of-string
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.