Be/feature/CR-28 #3314
Be/feature/CR-28 #3314
Conversation
that listen for messages from a connected client
| sessionId: DEFAULT_USER_ID, | ||
| }; | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Let's get SessionMetadata from socket.data. I don't think we need extra logic here in decorator
| // eslint-disable-next-line no-param-reassign | ||
| const jwt = socket.handshake.headers.authorization?.split(' ')[1]; | ||
| socket.data['jwt'] = jwt || null; | ||
|
|
There was a problem hiding this comment.
We must calculate (basically hardcode) SessionMetadata here and put into socket.data
For other builds we will have own Adapter with own custom logic (like validation or whatever is needed for any input) but as result of this adapter we must put SessionMetadata into socket.data field
|
Also seems like you've broke integration tests :) |
| @@ -41,6 +42,7 @@ export const getServer = async () => { | |||
| app.use(bodyParser.json({ limit: '512mb' })); | |||
| app.use(bodyParser.urlencoded({ limit: '512mb', extended: true })); | |||
| app.use('/static', express.static(serverConfig.get('dir_path').staticDir)) | |||
| app.useWebSocketAdapter(new SessionMetadataAdapter(app)); | |||
There was a problem hiding this comment.
@arthosofteq this is the line of code I had to add for the BE integration tests to pass
pass SessionMetadata to profiler
|
arthosofteq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
nelsonwellsredis
merged commit c41bf39
into
feature/dynamic-dependencies
No description provided.