Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.INSERTARR backward compatability for 1.0 #343

Merged
merged 6 commits into from
May 5, 2021
Merged

JSON.INSERTARR backward compatability for 1.0 #343

merged 6 commits into from
May 5, 2021

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented May 4, 2021

fix #286

@gkorland gkorland requested review from gavrie and oshadmi May 4, 2021 14:25
@gkorland gkorland changed the title backward compatability for 1.0 JSON.INSERTARR backward compatability for 1.0 May 4, 2021
gavrie
gavrie reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@gavrie gavrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a classical case where having a test that fails before the fix and passes afterwards would be desirable.

@gkorland
Copy link
Contributor Author

gkorland commented May 4, 2021

@gavrie the regression described in #286.
Anyway I added more tests that were missing.

oshadmi
oshadmi reviewed May 4, 2021
View reviewed changes
tests/pytest/test.py Outdated Show resolved Hide resolved
tests/pytest/test.py Outdated Show resolved Hide resolved
@gkorland gkorland requested review from gavrie and oshadmi May 4, 2021 20:02
@gkorland gkorland merged commit 283ceae into master May 5, 2021
@gkorland gkorland deleted the arr_index branch May 5, 2021 08:52
oshadmi added a commit that referenced this pull request May 5, 2021
@rafie @gkorland
@oshadmi @TomerHekmati @gavrie
[feature-search-json] Sync with master (2) (#344)
93e471f 
* Update to Redis 6.2.2 (#332)

* Fix json.arrappend performance (#324)

* improve arr_pop, arr_insert & arr_trim performance 
* refactor do_json_* functions

* normalize index for backward (#327)

* normalize index for backward
* adpat for full backward with 1.0.x

* fix #318 (#333)

* CircleCI: macOS and benchmark fixes (#337)

* Update config.yml (#338)

* Add JSON.CLEAR command (#306)

* Restore optional path (default is $) for JSON.DEL

* Add JSON.CLEAR

* Handle JSON.CLEAR with $ path

* Add JSON.CLEAR - Fix failure in test:testSetInvalidPathShouldFail

* Idiomatic fixes per Gavrie review

Co-authored-by: Guy Korland <gkorland@gmail.com>

* Update RS_VERSIONS

last promoted builds

* Document flags for running tests

* fix arr_pop backward to 1.0 (#345)

* JSON.INSERTARR backward compatability for 1.0 (#343)

* Fix JSON.INSERTARR backward compatibility with 1.0.x
* Update test.py

* Fix build error
(use of undeclared crate or module `rawmod`)

* Fix format

Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
Co-authored-by: tomerhekredis <72793005+tomerhekredis@users.noreply.github.com>
Co-authored-by: Gavrie Philipson <gavrie@philipson.co.il>
Co-authored-by: oshadmi <omer.shadmi@redislabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavrie gavrie gavrie approved these changes

@oshadmi oshadmi oshadmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON.ARRINSERT regression?
3 participants
@gkorland @gavrie @oshadmi