[feature-search-json] Sync with master (2) #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve arr_pop, arr_insert & arr_trim performance * refactor do_json_* functions
* normalize index for backward * adpat for full backward with 1.0.x
* Restore optional path (default is $) for JSON.DEL * Add JSON.CLEAR * Handle JSON.CLEAR with $ path * Add JSON.CLEAR - Fix failure in test:testSetInvalidPathShouldFail * Idiomatic fixes per Gavrie review Co-authored-by: Guy Korland <gkorland@gmail.com>
last promoted builds
Update RS_VERSIONS
oshadmi
reviewed
May 4, 2021
src/lib.rs
Outdated
| @@ -4,8 +4,7 @@ extern crate redis_module; | |||
| use std::{i64, usize}; | |||
|
|
|||
| use redis_module::raw::RedisModuleTypeMethods; | |||
| use redis_module::{native_types::RedisType, NotifyEvent}; | |||
| use redis_module::{raw as rawmod, NextArg}; | |||
| use redis_module::{native_types::RedisType, NextArg, NotifyEvent}; | |||
There was a problem hiding this comment.
raw as rawmod was excluded from merge, should be something like:
use redis_module::{native_types::RedisType, NextArg, NotifyEvent, raw as rawmod};
* Fix JSON.INSERTARR backward compatibility with 1.0.x * Update test.py
(use of undeclared crate or module `rawmod`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.