Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite #6

Merged
merged 19 commits into from
Jun 5, 2017
Merged

Test suite #6

merged 19 commits into from
Jun 5, 2017

Conversation

hootnot
Copy link
Contributor

@hootnot hootnot commented Jun 4, 2017

  • testsuite added in the distutils standard way
  • setup.py modified a lot :
    • will retrieve the version from init instead hardcoded to make versioning easier
    • will fetch requirements from requirements.txt, no errors from double admin.
    • setup.py publish gives you the git command to tag the last version : configure .travis.yml with a deploy attribute and it will enable you to deploy to pypi from Travis using twine
  • added pyth 3.3 / 3.4 and 3.6 : also passing
  • version badge added (right versions will show up after merging)
  • implement coverage ? (it's easy to hook up coveralls) (and landscape / codacy)

Personally I deploy to pypi from Travis: bump the version in __init__, update your master, tag it and you are done.

  • rewrite README.md to README.rst : reason I rewrote my README.md's to README.rst's is because pypi likes .rst files a lot better. If you have a README.rst and modify the setup.py for that, then the deployment to pypi will show the README there also.

This setup is partially based on work of Tom Christie, @tomchristie, author of the Django Rest Framework, he wrote an article about depoying to pypi: https://tom-christie.github.io/articles/pypi/. For some of my own packages I've extended that a lot.

Travis has some annoying differences between the different environments. Sometimes you run into them

@itamarhaber
Copy link
Collaborator

@hootnot waiting for the fat lady to sing, but this looks great!

@hootnot
Copy link
Contributor Author

hootnot commented Jun 5, 2017

do you want me to fix README from md to rst ?

@tomchristie
Copy link

That'd be @tom-christie.

@itamarhaber
Copy link
Collaborator

rst makes more sense given your argument and experience, thanks for that too. I'll merge as is unless you plan to add coverage (yes please!).

@hootnot
Copy link
Contributor Author

hootnot commented Jun 5, 2017

Fixed the setEncoder/setDecoder internal links. Should be it now.

You can merge now if you like.

To setup coverage you need to modify .travis.yml with a key from coveralls.io . You are the boss! so you have to do this because of key related stuf.

Lets handle this one first

@itamarhaber
Copy link
Collaborator

Thanks again -merging and starting to think about releasing the next version codenamed "hootnot" :)

@itamarhaber itamarhaber merged commit 12a15ee into RedisJSON:master Jun 5, 2017
@hootnot
Copy link
Contributor Author

hootnot commented Jun 5, 2017

... I would be honoured :-), saw the 95% coverage too. A few extra tests and you have it 100%.

The version still sits on 2.7, that is because that info is retrieved from pypi and not from the master as I wrote in the PR. So when you upload a new release that is fixed.

@hootnot hootnot deleted the test-suite branch June 5, 2017 13:41
@itamarhaber
Copy link
Collaborator

In case I forgot to say it, thank you. After taking the project for a test drive, it feels like I moved from

to

Getting this atm, but I'm sure it is something that I missed:

$ pip install rejson
Collecting rejson
  Downloading rejson-0.2.0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-EobKFa/rejson/setup.py", line 22, in <module>
        requirements = map(str.strip, open("requirements.txt").readlines())
    IOError: [Errno 2] No such file or directory: 'requirements.txt'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-EobKFa/rejson/

@itamarhaber itamarhaber mentioned this pull request Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants