Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contentSchema keyword #1599

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Conversation

onavratil-monetplus
Copy link
Contributor

What/Why/How?

Added contentSchema keyword.

#1598 (comment)

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@onavratil-monetplus onavratil-monetplus requested a review from a team as a code owner June 24, 2024 08:25
Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: f65160c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr
Copy link
Contributor

tatomyr commented Jun 24, 2024

Thanks for the contribution @onavratil-monetplus! Could you also add a patch level changeset as described in the contributing guide?

@onavratil-monetplus onavratil-monetplus requested a review from a team as a code owner June 26, 2024 08:38
@onavratil-monetplus
Copy link
Contributor Author

Done, i included cli as well since the changes affect its behavior.

@tatomyr
Copy link
Contributor

tatomyr commented Jun 28, 2024

Oh, looks like you added the changeset file two times. Could you remove one? Otherwise all good, only waiting for @Redocly/technical-writers approval.

@onavratil-monetplus
Copy link
Contributor Author

Sorry for the mix-up. Should be fixed now.

Copy link
Collaborator

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is fine

Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @onavratil-monetplus for making Redocly CLI better!
Your changes will become available in the next release.

@tatomyr tatomyr merged commit 6534300 into Redocly:main Jul 1, 2024
27 checks passed
tatomyr added a commit that referenced this pull request Jul 1, 2024
tatomyr added a commit that referenced this pull request Jul 1, 2024
@jeremyfiel
Copy link
Contributor

fixes #1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants