For iOS 13, setting the ModalPresentationStyle to FullScreen #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove your changes to the csproj files and just include the .cs file change? |
|
@Redth I tried again. |
Merged
|
Thanks for your contribution! I've done a lot of work to modernize the ZXing.Net.Mobile code base and have merged those changes into master. I've included fixes from your PR manually. Please open a new issue or PR if you have more suggestions or changes. Thank you so much for your help! |
|
@Redth Is it possible to put this fix also in 2.X.X release. Unfortunately my project requires this fix and I am not in a position to upgrade this library to 3.X because of other dependencies. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was changed the ModalPresentationStyle of ZXingScannerViewController to FullScreen mode, in iOS 13 it was showing as a popup.