Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for illegal modification of Y in xGEMV. #622

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

matcross
Copy link
Contributor

@matcross matcross commented Sep 19, 2021

At NAG we've observed that Apple vecLib modifies Y on output from SGEMV and DGEMV when TRANS is 'T', M is zero, and N is nonzero.
Here is a test case for all four xGEMV's and four xGBMV's.
(It looked unnecessary to try to incorporate this into the data-file mechanism that the xblat2 tests use, so I hope this is OK.)

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #622 (6c876d4) into master (85ef8de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1894     1894           
  Lines      184021   184021           
=======================================
  Misses     184021   184021           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ef8de...6c876d4. Read the comment docs.

Copy link
Collaborator

@weslleyspereira weslleyspereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Your tests make sense to me, I don't think it is necessary to change the input files.

@weslleyspereira weslleyspereira merged commit 25274df into Reference-LAPACK:master Apr 15, 2022
@julielangou julielangou added this to the LAPACK 3.11.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants