Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Upgrade from 2.5.3 to 2.5.7 #598

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Oct 15, 2019

Context

  • Update Ruby from 2.5.3 to 2.5.7 (security and other bugfixes, etc.)
  • Incidentally, the newer Ruby 2.5.7-slim Docker image is based on Debian 10 "Buster" by default, as opposed to Debian 9 "Stretch" for the older Ruby 2.5.3-slim Docker image.

Release Notes

Here are the release notes for Ruby versions from 2.5.4 to 2.5.7:

Summary of Changes

  • Update .ruby-version
  • Update Dockerfile
  • Update Gemfile and Gemfile.lock
  • Update README.md

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Oct 15, 2019

I tested this manually in a local Docker container, and it seemed fine.

CI is broken for unrelated reasons.

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Oct 26, 2019

Planning to merge today if no conflicts with the other two PRs.

@DeeDeeG DeeDeeG force-pushed the ruby-2.5.7 branch 2 times, most recently from 48338b5 to c41c3cf Compare October 26, 2019 15:31
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Oct 26, 2019

I added a small workaround for failing tests to this PR.

It involves setting an environment as follows: OPENSSL_CONF=/etc/ssl/. See this StackOverflow question for details: https://stackoverflow.com/questions/53355217/genymotion-throws-libssl-conf-so-cannot-open-shared-object-file-no-such-file-o

I assume this has to do with the base image for ruby:2.5.7-slim being Debian 10 "Buster", as opposed to Debian 9 "Stretch," which is the base image for the older ruby:2.5.3-slim.

When running the tests, cliver tries to check that PhantomJS's version
is within a certain range, by running "phantomjs --version".

The "phantomjs --version" command fails for some reason
on the new ruby:2.5.7-slim Docker base image.

Perhaps because the new Docker image is based on Debian 10 "Buster,"
whereas the old Docker image was based on Debian 9 "Stretch"?

This commit's workaround allows "phantomjs --version" to work again.
@DeeDeeG DeeDeeG merged commit 05c74cb into RefugeRestrooms:develop Oct 26, 2019
@mi-wood mi-wood mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant