Improve organization in contact/restroom models #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
changed the title
|
I have looked at this, but I'm not great with Ruby (I know just enough to contribute some fixes or the most basic review), so assessing changes like this is honestly beyond what I know of the language. I can "approve" this for being a good-faith contribution for making the code better, but I would hold back on merging it until someone who knows Ruby better can take a look. Thanks for this contribution. |
DeeDeeG
approved these changes
Oct 28, 2020
DeeDeeG
added
Hacktoberfest
tkwidmer
approved these changes
Mar 9, 2021
DeeDeeG
added a commit
that referenced
this pull request
Mar 16, 2021
* Enable puma clustered (#654) Enable puma clustered mode to process more requests and reduce latency * Use a volume to deal with bundled gems (#640) This way we don't need to rebuild everytime we add/update/remove a gem * Improve organization in contact/restroom models (#653) * Remove unused git keep from models * Improve identation/organization of Contact form * Improve Restroom model organization by grouping method kinds * Update dependencies for early March 2021 (#658) * Dockerfile: Update NodeJS to version 14 * yarn.lock: Bump ini from v1.3.5 to v1.3.8 * yarn.lock: Bump dompurify from v2.0.8 to v2.2.6 * Gemfile.lock: Bump nokogiri from 1.10.10 to 1.11.1 * Gemfile[.lock]: Update rails to v5.2.4.5 Was version 5.2.4.4 (this is a patch version bump) * Ruby: Update from 2.5.8 to 2.6.6 * Gemfile[.lock]: Update webmock (v3.2.1 to v3.12.1) Also update its transitive dependencies, within ranges allowed by Gemfile. * Ruby: Update from 2.6.6 to 2.7.1 * Ruby: Update from 2.7.1 to 2.7.2 * Gemfile.lock: Update puma from 5.0.2 to 5.2.2 * yarn.lock: Update elliptic from v6.5.3 to v6.5.4 * Revert "Enable puma clustered (#654)" (#659) This reverts commit 6c63546. We don't know for sure that we need these speed/latency gains, and maintenance bandwidth is low for the project. We don't want to potentially have to track down bugs, or undo any damage done, so revert this change for now. Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Checklist