Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable puma clustered (#654)" #659

Merged
merged 1 commit into from Mar 10, 2021
Merged

Revert "Enable puma clustered (#654)" #659

merged 1 commit into from Mar 10, 2021

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Mar 10, 2021 •
edited

Context

Summary of Changes

  • Go back to using a single process of Puma.
    • We don't have metrics/traffic numbers to motivate the switch to multiple workers on a speed/latency basis. And the app hasn't been thoroughly tested with the multiple workers.
    • We honestly don't understand the potential implications of multiple workers.
    • Revert out of an abundance of caution, as we're making a new release to production soon.

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

@DeeDeeG
Revert "Enable puma clustered (#654)"
f209c95 
This reverts commit 6c63546.

We don't know for sure that we need these speed/latency gains,
and maintenance bandwidth is low for the project.

We don't want to potentially have to track down bugs,
or undo any damage done, so revert this change for now.
@DeeDeeG DeeDeeG merged commit 59bfd6a into develop Mar 10, 2021
@DeeDeeG DeeDeeG deleted the revert-puma-multiple-workers branch March 10, 2021 03:10
@DeeDeeG DeeDeeG mentioned this pull request Mar 10, 2021
Merged
5 tasks
DeeDeeG added a commit that referenced this pull request Mar 16, 2021
@DeeDeeG @brunoocasali
Release 1.20.1 (#660)
5d331a3 
* Enable puma clustered (#654)

    Enable puma clustered mode to process more requests and reduce latency

* Use a volume to deal with bundled gems (#640)

    This way we don't need to rebuild everytime we add/update/remove a gem

* Improve organization in contact/restroom models (#653)

  * Remove unused git keep from models

  * Improve identation/organization of Contact form

  * Improve Restroom model organization by grouping method kinds

* Update dependencies for early March 2021 (#658)

  * Dockerfile: Update NodeJS to version 14

  * yarn.lock: Bump ini from v1.3.5 to v1.3.8

  * yarn.lock: Bump dompurify from v2.0.8 to v2.2.6

  * Gemfile.lock: Bump nokogiri from 1.10.10 to 1.11.1

  * Gemfile[.lock]: Update rails to v5.2.4.5

      Was version 5.2.4.4 (this is a patch version bump)

  * Ruby: Update from 2.5.8 to 2.6.6

  * Gemfile[.lock]: Update webmock (v3.2.1 to v3.12.1)

      Also update its transitive dependencies,
      within ranges allowed by Gemfile.

  * Ruby: Update from 2.6.6 to 2.7.1

  * Ruby: Update from 2.7.1 to 2.7.2

  * Gemfile.lock: Update puma from 5.0.2 to 5.2.2

  * yarn.lock: Update elliptic from v6.5.3 to v6.5.4

  * Revert "Enable puma clustered (#654)" (#659)

      This reverts commit 6c63546.

      We don't know for sure that we need these speed/latency gains,
      and maintenance bandwidth is low for the project.

      We don't want to potentially have to track down bugs,
      or undo any damage done, so revert this change for now.

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DeeDeeG