update to new maps public key #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
DeeDeeG
reviewed
Oct 10, 2022
Comment on lines
-103
to
+104
| expect(page).to have_css("div#mapArea", visible: :visible) | ||
| page.has_css?(".nearby-container .listItem", visible: :visible) |
There was a problem hiding this comment.
I think the original CSS selector was correct here. (New one was probably copy-pasted from a nearby spec by accident?)
Looking to revert this back to the previous CSS selector soon if that's okay.
(Already said it elsewhere, but thanks again for fixing all this, and the dependency updates are appreciated as well.)
DeeDeeG
added a commit
that referenced
this pull request
Oct 11, 2022
* Fixes Apple M1 Issue w/ Docker (#672) - This causes problems in docker+apple m1 (`ActiveSupport::EventedFileUpdateChecker` isn't working on Docker for Apple Silicon (M1) at the moment.) More here: evilmartians/terraforming-rails#34 - Make sure we use amd64 for Mac OS X M1 compatibility * Update Dependencies for May 2022 (#673) - ruby: Upgrade Ruby from 2.7.5 to 2.7.6 - Gemfile.lock: Update nokogiri from 1.13.3 to 1.13.6 - Gemfile[.lock]: Update rails (5.2.6.3 --> 5.2.8) and its dependencies Also updates a few indirect dependencies. Specifically: concurrent-ruby, i18n, loofah, mini_mime, and thor. - Gemfile.lock: Update puma from 5.6.2 to 5.6.4 - yarn.lock: Update minimist from 1.2.5 to 1.2.6 - yarn.lock: Update node-forge from 1.2.1 to 1.3.1 - yarn.lock: Update swagger-ui from 4.1.3 to 4.7.0 Also update some of its dependencies, such as @braintree/sanitize-url. - yarn.lock: Update async from 2.6.3 to 2.6.4 - Revert "yarn.lock: Update swagger-ui from 4.1.3 to 4.7.0" It broke when updating, not sure why. Possibly webpack-related??? Back to swagger-ui 4.1.3. - deps: Resolve @braintree/sanitize-url to v6.x Was v5.x. (This is a JS dependency, in package.json and yarn.lock.) - yarn.lock: Update eventsource from 1.0.7 to 1.1.1 - Gemfile.lock: Update rack from 2.2.3 to 2.2.3.1 * update to new maps public key (#675) - update to new public key - upgrade to rails 6 - add net gems to Gemfile - update lock file - fix linting errors with upgrade - use proper "visible" syntax - update API gems - change to old css rspec helper * Update dependencies for early October 2022 (#676) - yarn.lock: Update terser - yarn.lock: Dedupe dependencies - ruby: Bump Ruby from 3.1.0 to 3.1.2 (Was recently updated from 2.7.6 to 3.1.0 in PR 675) Co-authored-by: Mikena Wood <mi-wood@users.noreply.github.com> Co-authored-by: Ernesto Tagwerker <ernesto+github@ombulabs.com>
This was referenced Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context