Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuclear reactor blew up without any blast effects when I was spectating #11607

Closed
1 of 2 tasks
mygamingaccount opened this issue Mar 20, 2023 · 5 comments
Closed
1 of 2 tasks
Assignees
Labels
Bug Something isn't working Code Programming task Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason Networking Issue related to multiplayer or networking

Comments

@mygamingaccount
Copy link

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

I was spectating, someone was doing the funny, the reactor was set to blow up and since the crew didn't react in time it did.

It was very anti-climactic, there was no flash, no explosion effect, the hull just disappeared.
Reporting on a singular occurrence

Keywords I searched for: missing explosion. No detonation. Explosion effect while spectate, spectator, spectating.

Reproduction steps

No response

Bug prevalence

Just once

Version

v1.0.8.0

-

No response

Which operating system did you encounter this bug on?

Linux

Relevant error messages and crash reports

No response

@mygamingaccount mygamingaccount changed the title Nuclear reactor blew up without the any blast effect when I was spectating Nuclear reactor blew up without any blast effects when I was spectating Mar 20, 2023
@itchyOwl
Copy link
Collaborator

Thanks for the report! So it only happened once, not consistently or often?

@itchyOwl itchyOwl added Bug Something isn't working Code Programming task Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason Networking Issue related to multiplayer or networking labels Mar 28, 2023
@Ek-Videogames
Copy link

Can confirm explosions sometimes have no particles, glow, or their default "underwaterexplosion" - can happen both in SP & MP, and not exclusive to spectator cam.

@Regalis11 Regalis11 added Need more info Insufficient information to resolve the issue (e.g. steps to reproduce a bug) and removed Need more info Insufficient information to resolve the issue (e.g. steps to reproduce a bug) labels Jul 13, 2023
@giists
Copy link
Collaborator

giists commented Jul 18, 2023

Seems like this only happens on some subs when playing multiplayer. I was able to repro this on Azimuth, Barsuk, Kastrull and Typhon by overheating the reactor

@Regalis11 Regalis11 assigned Regalis11 and unassigned giists Jul 18, 2023
@Regalis11
Copy link
Collaborator

Regalis11 commented Jul 18, 2023

Fixed in https://github.com/Regalis11/Barotrauma-development/commit/a4e1bd05b88d46bd43faef8ec1a250674e06e86a

Fixed nuclear reactor's explosion effects sometimes not being visible client-side.
The issue might've caused inconsistent behavior in other situations too: the problem here was the items didn't necessarily break in the same order client-side as they did server-side, because the server only marked the items as needing a condition update, and then sent those condition updates in Item.Update, meaning the update order of the items affected the order in which the client receives the updates. In the case of the reactor, the issue was that it only created the explosion if there was fuel inside it when it breaks, and then set the rods to 0% condition. If a client broke the rods before the reactor, the explosion effect wouldn't get executed.

@giists giists self-assigned this Jul 21, 2023
@giists
Copy link
Collaborator

giists commented Jul 21, 2023

Didn't encounter this anymore after testing, closing.

@giists giists closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason Networking Issue related to multiplayer or networking
Projects
None yet
Development

No branches or pull requests

5 participants