Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pause menu: #192

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

Jabka666
Copy link
Contributor

@Jabka666 Jabka666 commented Aug 26, 2022

  • Increased height of pause menu. Now it looks more proportionate;
  • Fixed an inaccuracy showing a map seed instead of selected map name while playing on selected map;
  • Made a capitalization of the buttons name which is more stylistically;
  • Moved some ticks closer to each other in Advanced tab;
  • Aligned buttons width;
  • Fixed an inaccuracy showing the Load Game button while playing on Perma Death mode;
  • Made a small spacing alignment between buttons;
  • Added forgotten scale factor on the line #7701.
    Initial commit without buttons name capitalization: 17203591f83dc92267bbcccf570e06c9fc579ca2
    Before:
    image
    image
    After:
    image
    image

- Increased height of pause menu. Now it looks more proportionate;
- Fixed an inaccuracy showing a map seed instead of selected map name while playing on selected map;
- Made a capitalization of the buttons name which is more stylistically;
- Moved some ticks closer to each other in "Advanced" tab;
- Aligned buttons width;
- Fixed an inaccuracy showing the "Load Game" button while playing on "Perma Death" mode;
- Made a small spacing alignment between buttons;
- Added forgotten scale factor on the line #7701.
Copy link
Contributor Author

@Jabka666 Jabka666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING! Forgot to discard Ideal Parameters here!

@ChronoQuote
Copy link

Seems to me like the boxes in the advanced tab were spaced apart as a way of grouping them into categories. Also, AA text looks isolated in both the before and after... maybe it should be grouped like normal and only be moved down while the framelimit slider is visible?

@Jabka666
Copy link
Contributor Author

Jabka666 commented Aug 27, 2022

Seems to me like the boxes in the advanced tab were spaced apart as a way of grouping them into categories. Also, AA text looks isolated in both the before and after... maybe it should be grouped like normal and only be moved down while the framelimit slider is visible?

Well yeah, would be better to move AAText upper. It looks isolated because of Framelimit slidebar. Don't forget that slidebars don't have a rescale, so on lower resolutions it can be overlapped

- The ``AAText`` checkbox has been moved closer to the others;
- Added ``MenuGray`` texture for locked buttons, ticks, inputboxes and etc.;
- Added ``ButtonSFX2`` sound while clicling on locked button or tick;
- Added new parameter in ``DrawButton`` function called "locked" for easier adding locked buttons;
- Moved down arrows in save and custom map menus;
- Added ability to delete custom map;
- Made a capitalization of the buttons name which is more stylistically (in Main Menu);
- Reduce menu height when the ``Framelimit`` or ``Usertrack`` options are hidden;
- Reduced the number of saves per page from 6 to 5;
- Fixed being able to press the ``BACK`` button when deleting a save;
- Fixed arrows shifting one pixel in the save and custom map menus;
- Slightly improved input boxes design (used ``DrawFrame`` instead of ``Rect``, so they stylistically similar to buttons and ticks).
@Jabka666
Copy link
Contributor Author

Jabka666 commented Sep 3, 2022

  • The AAText tick has been moved closer to the others;
  • Added MenuGray texture for locked buttons, ticks, inputboxes and etc.;
  • Added ButtonSFX2 sound while clicking on locked button or tick;
  • Added new parameter in DrawButton function called "locked" for easier adding locked buttons;
  • Moved down arrows in save and custom map menus;
  • Added ability to delete custom map;
  • Made a capitalization of the buttons name which is more stylistically (in Main Menu);
  • Reduce menu height when the Framelimit or Usertrack options are hidden;
  • Reduced the number of saves per page from 6 to 5;
  • Fixed being able to press the BACK button when deleting a save;
  • Fixed arrows shifting one pixel in the save and custom map menus;
  • Slightly improved input boxes design (used DrawFrame instead of Rect, so they stylistically similar to buttons and ticks).
    Before:
    image
    image
    image
    image
    After:
    image
    image
    image
    image

ChronoQuote and others added 6 commits September 3, 2022 08:14
- A "Back" wasn't all caps
- A "Page" wasn't all caps
- Two "Screen gamma"s didn't have a colon
- "Open/Close Inventory" was too long
- Center pause menu title text to match ending screen title text
- Move user track mode text to right of tick box like it is in main menu
- Declare TempStr as a local in menu drawing functions (and rename it to the more common strtemp)
- Center save file and custom map info text
- Fix SlideBar "LOW" and "HIGH" text being considerably lower than the bar
- Horizontally center "YES" and "NO" deletion confirmation buttons
- Better align "ACHIEVEMENTS" and "MAIN MENU" buttons on ending screen
- Make achievement menu page buttons square and add disabled buttons to match load game/load map page buttons
It looks perfect at native 1024p now, but due to rounding errors with the menu scaling system, some menu elements still get misaligned by 1px at higher resolutions... I think ideally all coordinates should be floats, and nothing should be multiplied by MenuScale until the moment buttons/frames are drawn. Removing all instances of *MenuScale would be a hassle though...
- Added ``Enable launcher`` and ``Play startup videos`` ticks;
- Automatically turn off antialiasing option while playing in non-fullscreen mode. Also make the tick locked;
- Don't used ``True/False`` statements in ``options.ini`` anymore;
- Hide ``Open console on error`` option when the ``Enable console`` is turned off.

Note: Use ``PlayStartup`` variable in ``PlayStartupVideos`` function when the PR ``Better PlayStartupVideos function Regalis11#205`` will be merged.
@Jabka666
Copy link
Contributor Author

Jabka666 commented Sep 3, 2022

  • A Back inscription wasn't all caps;
  • A Page inscription wasn't all caps;
  • Two Screen gamma inscriptions didn't have a colon;
  • Open/Close Inventory/Console was too long -> Changed to Toggle Inventory/Console;
  • Adjusted some frames by 1px;
  • Added Enable launcher and Play startup videos ticks;
  • Automatically turn off antialiasing option while playing in non-fullscreen mode. Also make the tick locked;
  • Don't use True/False statements in options.ini anymore;
  • Hide Open console on error option when the Enable console is turned off.
  • Horizontally centered YES and NO deletion confirmation buttons;
  • Better aligned ACHIEVEMENTS and MAIN MENU buttons on ending screen;
  • Made achievement menu page buttons square and added disabled buttons to match load game/load map page buttons;
  • Centered pause menu title text to match ending screen title text;
  • Move user track mode text to right of tick box like it is in main menu;
  • Declare TempStr as a local in menu drawing functions (and rename it to the more common StrTemp);
  • Center save file and custom map info text;
  • Fixed SlideBar LOW and HIGH text being considerably lower than the bar.
    Final results:
    NEW GAME:
    image
    LOAD GAME:
    image
    LOAD MAP:
    image
    GRAPHICS:
    image
    AUDIO:
    image
    CONTROLS:
    image
    ADVANCED:
    image

- Used ``ResetInput`` to prevent clicking on the locked button while quitting the game;
- Added ``HidePointer`` while loading a game.
@Jabka666
Copy link
Contributor Author

Jabka666 commented Sep 3, 2022

  • Used ResetInput to prevent clicking on the locked button while quitting the game;
  • Added HidePointer while loading a game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants