Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET Core SDK 5.0.100 #266

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Upgrade to .NET Core SDK 5.0.100 #266

merged 1 commit into from
Nov 18, 2020

Conversation

RehanSaeed
Copy link
Owner

  • Upgrade to .NET Core SDK 5.0.100.
  • Use latestMajor .NET SDK.
  • Bump Cake.Tool from 0.38.5 to 1.0.0.
  • Update the .editorconfig file which has changed in a breaking way (Add Support for VS 16.8 Which Introduced Breaking Changes EditorConfig#42) to support VS 16.8.
  • Enable EnforceCodeStyleInBuild (This is awesome).
  • Fix all the new warnings.
  • Switch from is object to is not null. This has been on my mind for a long time. There is a lot more that could be done but getting some C# 9 in early.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning. labels Nov 17, 2020
Copy link
Collaborator

@krajek krajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea, thx

@RehanSaeed RehanSaeed merged commit 5c10cac into main Nov 18, 2020
@RehanSaeed RehanSaeed deleted the dotnet-5 branch November 18, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants