AB Email Notifications - Value Fix #2523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # interactive rebase in progress; onto da146c1 # Last command done (1 command done): # pick 585aea8 Fixed Value dropdowns and owner + user data persistence # Next commands to do (2 remaining commands): # pick 4e4cf83 Uncommented function # pick 5789c74 Capital comments fixed for dataset-filter page # You are currently rebasing branch 'value-fix' on 'da146c141'. # # Changes to be committed: # modified: libs/shared/src/i18n/en.json # modified: libs/shared/src/i18n/fr.json # modified: libs/shared/src/i18n/test.json # modified: libs/shared/src/lib/components/email/components/dataset-filter/dataset-filter.component.html # modified: libs/shared/src/lib/components/email/components/dataset-filter/dataset-filter.component.ts # modified: libs/shared/src/lib/components/email/email.service.ts # modified: libs/shared/src/lib/components/email/filter/filter.constant.ts # modified: libs/shared/src/lib/components/email/graphql/queries.ts #
…mit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # interactive rebase in progress; onto da146c1 # Last commands done (3 commands done): # pick 4e4cf83 Uncommented function # pick 5789c74 Capital comments fixed for dataset-filter page # No commands remaining. # You are currently rebasing branch 'value-fix' on 'da146c141'. # # Changes to be committed: # modified: libs/shared/src/lib/components/email/components/dataset-filter/dataset-filter.component.ts #
HasnatL-Adapptlimited
requested review from
AntoineRelief and
Matthis-M-ReliefApps
|
Hey @AntoineRelief, Apologies, don't want to confuse anyone we've reopened this PR as we did a few changes with our forked branch. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Base PR
Original PRs
Original Frontend PR
Old Backend PR
Related PR
Backend PR
In reference to this:
#2479 (comment)
Tickets