Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET Core] When using dotnet build Reloaded.Mod.Launcher cannot be used by consumers due defined PropertyChanged dependency. #17

Closed
Sewer56 opened this issue Jul 28, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Sewer56
Copy link
Member

Sewer56 commented Jul 28, 2019

See: Fody/Costura#358

Prologue

.NET Core, including .NET Core 3 use a JSON text file that explains file dependencies. This file is checked by the .NET Runtime and if a dependency is missing, the runtime refuses to load the application.

Problem

PropertyChanged is not actually needed by the assembly and thus not copied to the output folder during dotnet build. However the dependency is still present in the .deps.json file, and thus the launcher would refuse to boot.

Note: For developers, the library will still be found due to the runtimeconfig-dev.json configuration, pointing to NuGet cache folders, but end users wouldn't have said folders.

Temporary Workaround

Include dummy PropertyChanged.dll in project to be copied to output.

@Sewer56 Sewer56 added the help wanted Extra attention is needed label Aug 8, 2019
@Sewer56 Sewer56 closed this as completed Aug 19, 2020
@Sewer56
Copy link
Member Author

Sewer56 commented Aug 19, 2020

This issue is no longer relevant due to how Reloaded is built for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant