Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make steam hook work with Unreal Engine games #283

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

AnimatedSwine37
Copy link
Contributor

@AnimatedSwine37 AnimatedSwine37 commented Jan 28, 2024

Unreal Engine games have the steam api dll in a different folder from the game's exe so Steam Hook didn't work. This pr makes Reloaded attempt to search in the correct place for UE games, letting steam hook work with them.

As far as I can tell the folder structure is always consistent for UE games so this should work with any (hopefully I'm correct :D)

@Sewer56
Copy link
Member

Sewer56 commented Jan 28, 2024

This is a hack, but I'll allow it. Please mark it as so (with a comment) in the code. (Also that it targets UE4, as UE3 games don't apply here)

There is a potentially better way to do this, with hooking LdrLoadDll, and creating the Steam hook if we're loading Steam API, however given that R2 is in maintenance/bugfix as I work on R3, I'm happy to allow a hack like this.

@Sewer56 Sewer56 merged commit b068a4b into Reloaded-Project:master Jan 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants