Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test make install target #188

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

ClausKlein
Copy link
Contributor

@ClausKlein ClausKlein commented Jan 17, 2022

add more git ignore entries too

The install target does not work #189

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #188 (0dfc413) into master (e77735c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   65.27%   65.26%   -0.01%     
==========================================
  Files         568      569       +1     
  Lines       44609    44580      -29     
==========================================
- Hits        29118    29097      -21     
+ Misses      15491    15483       -8     
Impacted Files Coverage Δ
tao/x11/valuetype/valuetype_adapter_impl.cpp 70.00% <0.00%> (-2.42%) ⬇️
tests/out/client.cpp 61.70% <0.00%> (-2.30%) ⬇️
tests/idl_test/main.cpp 93.75% <0.00%> (-2.17%) ⬇️
tao/x11/system_exception.cpp 31.37% <0.00%> (-1.97%) ⬇️
tests/out/server.cpp 63.82% <0.00%> (-0.76%) ⬇️
tests/string/server.cpp 63.82% <0.00%> (-0.76%) ⬇️
tao/x11/logger/log_base.cpp 65.75% <0.00%> (-0.57%) ⬇️
tao/x11/anytypecode/any_unknown_type.cpp 67.85% <0.00%> (-0.29%) ⬇️
tests/ami_test/ami/client.cpp 68.25% <0.00%> (-0.13%) ⬇️
tests/ami_test/no_module/client.cpp 55.83% <0.00%> (-0.13%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77735c...0dfc413. Read the comment docs.

tao/x11/taox11.mpc Outdated Show resolved Hide resolved
Copy link
Member

@jwillemsen jwillemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the files that don't exist anymore instead of commenting them out

respect review comments
@@ -35,3 +36,48 @@ bin/MPC/config/MPC.cfg*
tao/x11/ifr_client/taox11_ifr_client_skel_export.h
tao/x11/ifr_client/taox11_ifr_client_stub_export.h
ridlbe/c++11/orb.pidlc
examples/log_module/output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should migrate to a .gitignore for each specific test

@ClausKlein
Copy link
Contributor Author

Note:

there are still many problems:

the ACE header will be not installed?

the tao header will be only partly installed?

klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$ find . -name x11
./tao/x11
./x11
klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$ find . -name x11 | xargs ls -l
./tao/x11:
total 0
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 18 11:18 dynamic_any

./x11:
total 0
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 bidir_giop
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 codecfactory
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 dynamic_any
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 ior_interceptor
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 ior_table
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 18 11:18 logger
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 messaging
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 ort
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 pi
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 pi_server
drwxr-xr-x 1 klein_cl klein_cl 512 Jan 19 09:40 typecodefactory
klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$

the pidl files are installed at a stange location?

klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$ find . -name DynamicAny
./DynamicAny
./x11/dynamic_any/home/klein_cl/Workspace/cpp/axcioma/ACE/TAO/tao/DynamicAny
klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$ find . -name DynamicAny | xargs tree
./DynamicAny
├── DynAnyFactory.h
├── DynAnyUtils_T.cpp
├── DynAnyUtils_T.h
├── DynAny_i.h
├── DynArray_i.h
├── DynCommon.h
├── DynEnum_i.h
├── DynSequence_i.h
├── DynStruct_i.h
├── DynUnion_i.h
├── DynValueBox_i.h
├── DynValueCommon_i.h
├── DynValue_i.h
├── DynamicAny.h
├── DynamicAny.pidl
├── DynamicAnyC.h
├── DynamicAnyS.h
└── dynamicany_export.h
./x11/dynamic_any/home/klein_cl/Workspace/cpp/axcioma/ACE/TAO/tao/DynamicAny
└── DynamicAny.pidl

0 directories, 19 files
klein_cl@WD003223:~/Workspace/cpp/axcioma/stage/include/tao$

@jwillemsen
Copy link
Member

The install feature has never been tested and is not supported for AXCIOMA/TAOX11. We currently don't have plans to add an install feature, see https://www.remedy.nl/services/opensource-support.html for our commercial services through which we could add this for you.

@jwillemsen jwillemsen added the enhancement New feature or request label Jan 19, 2022
@jwillemsen jwillemsen linked an issue Jan 19, 2022 that may be closed by this pull request
@ClausKlein
Copy link
Contributor Author

The install feature has never been tested and is not supported for AXCIOMA/TAOX11. We currently don't have plans to add an install feature, see https://www.remedy.nl/services/opensource-support.html for our commercial services through which we could add this for you.

How should someone use the SW if it is not installable?

We normaly use CMake projects!
Can you explain, how should I use the idl compiler in our CmakeLists.txt if the taox11 SW and its dependencies are not installed?

@jwillemsen jwillemsen merged commit acedb11 into RemedyIT:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The install target does not work
2 participants