Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark destructors with override #190

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

jwillemsen
Copy link
Member

* tao/x11/messaging/messaging_policy_impl.cpp:
* tao/x11/messaging/messaging_policy_impl.h:

    * tao/x11/messaging/messaging_policy_impl.cpp:
    * tao/x11/messaging/messaging_policy_impl.h:
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #190 (dfe907d) into master (9b3e372) will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   66.11%   65.26%   -0.85%     
==========================================
  Files         569      569              
  Lines       47963    44580    -3383     
==========================================
- Hits        31712    29097    -2615     
+ Misses      16251    15483     -768     
Impacted Files Coverage Δ
tao/x11/messaging/messaging_policy_impl.cpp 85.50% <ø> (-0.80%) ⬇️
tao/x11/anytypecode/any.cpp 41.01% <0.00%> (-15.16%) ⬇️
tests/mt/mt_bidir/server_task.cpp 66.66% <0.00%> (-14.29%) ⬇️
tests/collocation/collocation.cpp 71.42% <0.00%> (-11.91%) ⬇️
tao/x11/codecfactory/codecfactory.cpp 71.42% <0.00%> (-10.39%) ⬇️
tests/poa/forwarding/test_i.cpp 81.81% <0.00%> (-9.49%) ⬇️
tests/obv/valuebox/server.cpp 64.51% <0.00%> (-8.82%) ⬇️
tests/ami_test/ostream/test_i.cpp 66.66% <0.00%> (-8.34%) ⬇️
tests/poa/forwarding/client.cpp 62.50% <0.00%> (-7.96%) ⬇️
tests/obv/supports/supports_test_impl.cpp 60.60% <0.00%> (-7.58%) ⬇️
... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3e372...dfe907d. Read the comment docs.

@jwillemsen jwillemsen merged commit 01454fc into RemedyIT:master Jan 20, 2022
@jwillemsen jwillemsen deleted the jwi-destructoroverride2 branch January 20, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant