Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: update our singularity docker shim to fixup tests etc #42

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

yarikoptic
Copy link
Member

Unfortunately we do not have (yet) cron job running tests, so at some point things went awry and I am not sure when. This PR is WiP toward resolving them.

Part of the problem precluding update of our shim is also that singularity docker images are flawed - have no suid set, reported to @vsoch .

When done, it should close #40

Reported (well - asked if feature or a bug) Vanessa over IM.
Versions of the docker containers after 3.3.0 lack suid set for
the started-suid helper. That prevents running singularity within
docker container under a normal user privileges.
@vsoch
Copy link

vsoch commented Mar 26, 2020

@yarikoptic let me know how I can help. I can manually push the base with setuid for that particular slim tag, but it still remains a mystery why it wasn't there via the automated build.

@yarikoptic
Copy link
Member Author

Thank you @vsoch! I think with ad-hoc chmod as in the PR that issue is a non-issue for us ;) yet to figure out what other things have changed

Since 3.6.1 there is now /etc/localtime within those docker containers.
That forbids us to bind mount the correct one from outside, so I moved it
aside (may be we would need to adjust further, in particular whenever there
is no /etc/localtime outside -- may be we would need to provide/bind mount
some fixed one then
@yarikoptic yarikoptic merged commit 6fe18f8 into ReproNim:master Dec 10, 2020
@yarikoptic yarikoptic deleted the bf-docker branch December 10, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on Debian for me
2 participants