Enh workflow #84
Merged
Enh workflow #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Feb 13, 2023
yarikoptic
reviewed
Feb 13, 2023
asmacdo
commented
Feb 17, 2023
yarikoptic
requested changes
Feb 17, 2023
README.md
Outdated
| ``` | ||
|
|
||
| Now we can "freeze" a container or containers that we plan to use so | ||
| anyone (including you) will know exactly which version was used. This is |
There was a problem hiding this comment.
Suggested change
| anyone (including you) will know exactly which version was used. This is | |
| anyone (including you) will know exactly which version was used and if you upgrade | |
| the containers dataset to new version with newer versions of containers - you would need | |
| to concisely choose to either upgrade this one or not while resolving conflicts. This is |
README.md
Outdated
| Now we can "freeze" a container or containers that we plan to use so | ||
| anyone (including you) will know exactly which version was used. This is | ||
| technically optional, but very helpful. (All that changes is a | ||
| subproject commit hash.) |
There was a problem hiding this comment.
I have remembered one "cons" for this IMHO worth noting. Please incorporate something like
Suggested change
| subproject commit hash.) | |
| subproject commit hash.) A disadvantage though is that if you were to make | |
| others to reproduce the results, you would need to share your clone of `///repronim/containers` | |
| to share that updated state with frozen version in `.datalad/config`. |
There was a problem hiding this comment.
Please re-read this section, I rewrote it with your ideas included.
README.md
Outdated
|
|
||
| If everything worked as expected, we will now see our new analysis, and | ||
| a commit message of how it was obtained! | ||
|
|
||
| and now you have a dataset which has a git record on how these data |
There was a problem hiding this comment.
join into above or just make it capitalized
There was a problem hiding this comment.
joined in and rewrote.
asmacdo
force-pushed
the
enh-workflow
branch
from
121ab2d
to
dad029c
Compare
asmacdo
commented
Feb 20, 2023
yarikoptic
requested changes
Feb 24, 2023
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81