ENH: Don't list resources if loading a known resource fails #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually importing a resource fails because the user has passed an unknown resource type, so we report the known resources in the exception message. But if the import of a known resource fails (e.g., because the resource imports an uninstalled module), it's confusing to show a list of known resources. Closes ReproNim#297.
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 88.59% 88.63% +0.04%
==========================================
Files 133 133
Lines 9582 9635 +53
==========================================
+ Hits 8489 8540 +51
- Misses 1093 1095 +2
Continue to review full report at Codecov.
|
yarikoptic
reviewed
Oct 18, 2018
niceman/resource/base.py
Outdated
| @@ -134,10 +134,12 @@ def factory(config): | |||
| except Exception as exc: | |||
| # Typically it should be an ImportError, but let's catch and recast | |||
| # anything just in case. | |||
| msg = exc_str(exc) | |||
| known = ResourceManager._discover_types() | |||
There was a problem hiding this comment.
I wouldn't be surprised if we manage to raise exception there as well, so may be try/except these 3 lines as well and add caught exception message (msg += " Failed to discover resource types: %s" % exc_str(exc2)) in except for it?
There was a problem hiding this comment.
Seems like an overkill to me, but as you wish.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually importing a resource fails because the user has passed an
unknown resource type, so we report the known resources in the
exception message. But if the import of a known resource fails (e.g.,
because the resource imports an uninstalled module), it's confusing to
show a list of known resources.
Closes #297.