Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] refactor documentation #487

Merged
merged 25 commits into from
Jun 14, 2024
Merged

[REF] refactor documentation #487

merged 25 commits into from
Jun 14, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented May 10, 2024

What this PR does:

  • extracts from the doc any jsonld code blocks and store them in actual jsonld files that can be validated with reproschema-py. The files are then directly "injected" in the documentation. This makes sure that the jsonld presented in the doc is always valid according to the reproschema.
  • merge FAQ pages
  • remove glossary as most definitions are already part of the schema

@Remi-Gau Remi-Gau mentioned this pull request May 10, 2024
9 tasks
@Remi-Gau
Copy link
Collaborator Author

Will try to extend the logic of this PR to extract all files examples from the doc into actual files so their content can be properly validated.

Because the user guide is based on the reproschema-demo-protocol: https://github.com/ReproNim/reproschema-demo-protocol
I wonder if we should not sub-module it into this repo, so file content can directly be "injected" into the doc.

@yibeichan
Copy link
Contributor

@Remi-Gau I finally have some time to think about our overall documentation; here is the plan:
currently we have
User Guide

  • Create a research protocol
  • Adopt assessments from the library
  • Create new assessments for a protocol
  • Add a feedback section
  • Finalize the protocol
  • Toolkit

Tutorial

  • Intro
  • Create a research protocol
  • Creating a new activity
  • Tips to make your life easier
  • Translate a questionnaire
  • Demographic information

We want to change User Guide to something more like a manual, probably we should have one page for each repo (e.g., reproschema, reproschema-library, reproschema-py, reproschema-ui, reproschema-protocol-cookiecutter), where we detail the usage of each repo (currently i can only think of reproschema-library, reproschema-py,reproschema-protocol-cookiecutter)
for tutorials, we can merge Create a research protocol Adopt assessments from the library Create new assessments for a protocol in User Guide with Create a research protocol Creating a new activity in Tutorial
the current Demographic information can be merged into Adopt assessments from the library
the current Intro can be merged into Create a research protocol. if we want, we can write a new Intro

let me know what you think, we can meet and revise the plan, then split the task.

@yibeichan
Copy link
Contributor

Because the user guide is based on the reproschema-demo-protocol: https://github.com/ReproNim/reproschema-demo-protocol I wonder if we should not sub-module it into this repo, so file content can directly be "injected" into the doc.

okay I found myself lost in this sentence, haha. so what do we want to do and what should not do here?

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jun 7, 2024

Will update the top message to explain what the PR does because otherwise future me is lost when he gets back to it

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jun 7, 2024

Validation fails because there is a README.md file in amongst the jsonld files but this should be fixed when ReproNim/reproschema-py#40 is merged.

In the meantime I will run the validation with that branch from my fork.

@yibeichan
Copy link
Contributor

use this branch for validation
https://github.com/djarecka/reproschema-py/tree/ref/linkml

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jun 7, 2024

The user guide points to the demo protocol: if we update the demo protocol the user-guide may be out of synch with the content of the demo protocol repo.

May potentially be good to submodule the demo-protocol and read content directly from there.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jun 7, 2024

Similarly some of the examples I have generated are based on some of the content from that PR
ReproNim/reproschema-library#60

So once this gets merged, we could use the same strategy of submoduling the library and read jsonld content directly from there: this may also allows us to give a listing of the content of the library as part of the documentation.

@Remi-Gau Remi-Gau marked this pull request as ready for review June 7, 2024 14:26
@yibeichan
Copy link
Contributor

thank you!! @Remi-Gau i'm gonna merge this one now, once the new context URL is ready, I'll replace them. quick question: I saw all jsonld file has .jsonld extension, is it because we need this extension to help identify which file we want to validate (without .jsonld it would be hard to know which is which)? but in general, we don't add .jsonld in reproschema

@yibeichan yibeichan merged commit 99c321c into ReproNim:main Jun 14, 2024
4 checks passed
@Remi-Gau Remi-Gau deleted the fix/doc-2 branch June 15, 2024 07:24
@Remi-Gau
Copy link
Collaborator Author

we don't add .jsonld in reproschema

Let me turn the question around: why is it not the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants