refactor: factorize goerli tests (#893)

* refactor: factorize goerli tests * refactor: testSuite to testProvider * fix: delete goerli aggregator * feat: add void goerli chainlinkAggregator
RequestNetwork · Aug 3, 2022 · 282dbc2 · 282dbc2
1 parent 2495d00
commit 282dbc2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 53 deletions.
diff --git a/packages/currency/src/aggregators/goerli.json b/packages/currency/src/aggregators/goerli.json
diff --git a/packages/currency/src/chainlink-path-aggregators.ts b/packages/currency/src/chainlink-path-aggregators.ts
@@ -14,6 +14,7 @@ export type CurrencyPairs = Record<string, Record<string, number>>;
 export const chainlinkCurrencyPairs: Record<string, CurrencyPairs> = {
   private: privateAggregator,
   rinkeby: rinkebyAggregator,
+  goerli: {},
   mainnet: mainnetAggregator,
   matic: maticAggregator,
   fantom: fantomAggregator,

diff --git a/packages/payment-detection/test/any/any-to-erc20-proxy-contract.test.ts b/packages/payment-detection/test/any/any-to-erc20-proxy-contract.test.ts
@@ -78,7 +78,7 @@ describe('api/any/conversion-fee-proxy-contract', () => {
       });
     });
 
-    it(`can createExtensionsDataForCreation with fee amount and address ${network}`, async () => {
+    it(`can createExtensionsDataForCreation with fee amount and address on ${network}`, async () => {
       await anyToErc20Proxy.createExtensionsDataForCreation({
         feeAddress: 'fee address',
         feeAmount: '2000',
@@ -103,27 +103,6 @@ describe('api/any/conversion-fee-proxy-contract', () => {
   testSuite('rinkeby');
   testSuite('goerli');
 
-  it('can createExtensionsDataForCreation with fee amount and address (Goerli)', async () => {
-    await anyToErc20Proxy.createExtensionsDataForCreation({
-      feeAddress: 'fee address',
-      feeAmount: '2000',
-      paymentAddress: 'ethereum address',
-      salt: 'ea3bc7caf64110ca',
-      acceptedTokens: ['ethereum address2'],
-      network: 'goerli',
-    });
-
-    expect(createCreationAction).toHaveBeenCalledWith({
-      feeAddress: 'fee address',
-      feeAmount: '2000',
-      paymentAddress: 'ethereum address',
-      refundAddress: undefined,
-      salt: 'ea3bc7caf64110ca',
-      acceptedTokens: ['ethereum address2'],
-      network: 'goerli',
-    });
-  });
-
   it('can createExtensionsDataForCreation without salt', async () => {
     await anyToErc20Proxy.createExtensionsDataForCreation({
       paymentAddress: 'ethereum address',

diff --git a/packages/payment-detection/test/provider.test.ts b/packages/payment-detection/test/provider.test.ts
@@ -25,13 +25,6 @@ describe('getDefaultProvider', () => {
   testSuite('rinkeby', 4);
   testSuite('goerli', 5);
 
-  it('Can take a standard network (Goerli)', async () => {
-    const provider = getDefaultProvider('goerli');
-
-    expect(provider).toBeInstanceOf(providers.InfuraProvider);
-    await expect(provider.getNetwork()).resolves.toMatchObject({ chainId: 5 });
-  });
-
   it('Can take a private network', async () => {
     const provider = getDefaultProvider('private') as providers.JsonRpcProvider;
 

diff --git a/packages/payment-processor/test/payment/utils.test.ts b/packages/payment-processor/test/payment/utils.test.ts
@@ -99,23 +99,19 @@ describe('getNetworkProvider', () => {
     expect(getNetworkProvider(request)).toBeInstanceOf(providers.Provider);
   });
 
-  it('returns a provider for rinkeby', () => {
-    const request: any = {
-      currencyInfo: {
-        network: 'rinkeby',
-      },
-    };
-    expect(getNetworkProvider(request)).toBeInstanceOf(providers.Provider);
-  });
+  const testProvider = (network: string) => {
+    it(`returns a provider for ${network}`, () => {
+      const request: any = {
+        currencyInfo: {
+          network: network,
+        },
+      };
+      expect(getNetworkProvider(request)).toBeInstanceOf(providers.Provider);
+    });
+  };
 
-  it('returns a provider for goerli', () => {
-    const request: any = {
-      currencyInfo: {
-        network: 'goerli',
-      },
-    };
-    expect(getNetworkProvider(request)).toBeInstanceOf(providers.Provider);
-  });
+  testProvider('rinkeby');
+  testProvider('goerli');
 
   it('fails for other network', () => {
     const request: any = {