Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default currency list #1269

Open
benjlevesque opened this issue Nov 28, 2023 · 1 comment
Open

Reduce default currency list #1269

benjlevesque opened this issue Nov 28, 2023 · 1 comment

Comments

@benjlevesque
Copy link
Contributor

Context

As seen in #1268, the default currency manager is pretty heavy.

Originally, the RequestNetwork library knew about all currencies it could support, but since the introduction of CurrencyManager, it's highly configurable, and the expected usage is to specify the list of tokens.

Proposal

Remove most currencies from the default currency list, especially Metamask's default list.

I suggest we keep:

  • native tokens for all supported chains (although this should actually also be dynamic, based on an injected list of supported chains)
  • iso4217 currencies (need to confirm this is fast to load, but I think it should be)
  • a few mainstream ERC20 tokens for convenience

Compatibility

For compatibility, we could offer an async method loadExtendedCurrencyList to fetch the Metamask list, as well as currently hard-coded tokens.

@MantisClone
Copy link
Member

Related: #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐞🧹 Backlog: Bug, Tech Debt, or Chore
Development

No branches or pull requests

2 participants