Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace hardcoded address #1138

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: replace hardcoded address #1138

merged 1 commit into from
Aug 17, 2023

Conversation

MantisClone
Copy link
Member

Problem

#1127 (comment)

[hardcoded address] should be a variable or should have a comment

Description of the changes

  • fix: replace the hardcoded address with deployerAddress var from hardhat runtime environment hre

@MantisClone MantisClone self-assigned this Aug 16, 2023
@coveralls
Copy link

Coverage Status

coverage: 87.587%. remained the same when pulling e985794 on fix-deployer-address-variable into ae925f1 on master.

@MantisClone MantisClone enabled auto-merge (squash) August 16, 2023 17:52
@MantisClone MantisClone merged commit be4b677 into master Aug 17, 2023
28 checks passed
@MantisClone MantisClone deleted the fix-deployer-address-variable branch August 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-abrioux alexandre-abrioux alexandre-abrioux approved these changes

@olivier7delf olivier7delf olivier7delf approved these changes

@benjlevesque benjlevesque Awaiting requested review from benjlevesque

@kevindavee kevindavee Awaiting requested review from kevindavee

@leoslr leoslr Awaiting requested review from leoslr

@skiv71 skiv71 Awaiting requested review from skiv71

Assignees

@MantisClone MantisClone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MantisClone @coveralls @alexandre-abrioux @olivier7delf