fix: solana address validation #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benjlevesque,
kevindavee,
KolevDarko and
olivier7delf
leoslr
requested review from
MantisClone,
alexandre-abrioux and
jerrylaloan
and removed request for
KolevDarko,
kevindavee and
olivier7delf
benjlevesque
approved these changes
Oct 2, 2023
alexandre-abrioux
approved these changes
Oct 2, 2023
| @@ -246,7 +246,7 @@ export class CurrencyManager<TMeta = unknown> implements ICurrencyManager<TMeta> | |||
| case RequestLogicTypes.CURRENCY.ERC777: | |||
| if (NearChains.isChainSupported(currency.network)) { | |||
| return isValidNearAddress(address, currency.network); | |||
| } else if (currency.network === 'tron') { | |||
| } else if (currency.network === 'tron' || currency.network === 'solana') { | |||
There was a problem hiding this comment.
@leoslr Is it the fix or is the change of version of multicoin-address-validator also needed?
There was a problem hiding this comment.
Both are needed:
- We need to tackle solana case here
- The lib update was needed as well, version 5.2 didn't handle solana
MantisClone
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The validation was broken when trying to validate ERC20 currencies on Solana