Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: estimate gas fee #1186

Merged
merged 9 commits into from
Oct 6, 2023
Merged

refactor: estimate gas fee #1186

merged 9 commits into from
Oct 6, 2023

Conversation

benjlevesque
Copy link
Contributor

@benjlevesque benjlevesque commented Oct 3, 2023

Remove @rainbow-me/fee-suggestions from the utils package, to reduce dependencies in other packages.

@@ -60,6 +60,7 @@
"@nomiclabs/hardhat-web3": "2.0.0",
"@openzeppelin/contracts": "4.4.2",
"@openzeppelin/test-helpers": "0.5.6",
"@rainbow-me/fee-suggestions": "2.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev dependency

@coveralls
Copy link

coveralls commented Oct 4, 2023

Coverage Status

coverage: 87.383% (-0.09%) from 87.473% when pulling 92cd212 on refactor/estimate-gas-fee into aff90df on master.

Copy link
Member

@alexandre-abrioux alexandre-abrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

packages/utils/src/estimate-gas-fees.ts Outdated Show resolved Hide resolved
benjlevesque and others added 3 commits October 6, 2023 01:59
…asks.ts

Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
@benjlevesque benjlevesque merged commit a7b5043 into master Oct 6, 2023
26 of 27 checks passed
@benjlevesque benjlevesque deleted the refactor/estimate-gas-fee branch October 6, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants