Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: request network add sdk package #1196
feat: request network add sdk package #1196
Changes from 3 commits
460bfbc
67ad0de
4ac3616
08702f2
9274501
db9f569
48d8343
b6dfeba
c4171cf
77db3bd
7273f65
f6c8c17
f32aff9
f79301b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the references in here should match the version in the
package.json
of these packages. Right now, you are resolving the version on NPM, not the monorepo's versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benjlevesque thanks for this info, it really helped. Turned out it was because I used the @next modifier (as this has been promoted since I started).
Changed to the correct version(s) and all it well.
The latest commit also includes tsconfig changes to produce es6 output.