Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce eslint monorepo/no-relative-import rule #1200

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

MantisClone
Copy link
Member

Description of the changes

  • Add eslint-plugin-monorepo
  • Enable monorepo/no-relative-input eslint rule on all packages

@MantisClone MantisClone changed the title Enforce eslint monorepo/no-relative-import rule chore: enforce eslint monorepo/no-relative-import rule Oct 15, 2023
@MantisClone MantisClone marked this pull request as ready for review October 16, 2023 12:51
@@ -49,6 +49,7 @@
"devDependencies": {
"@types/jest": "26.0.13",
"@types/lodash": "4.14.161",
"eslint-plugin-monorepo": "0.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we install it in the main package.json instead? See other plugins here:

"eslint-plugin-import": "2.22.1",

Copy link
Member

@alexandre-abrioux alexandre-abrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment regarding the installation's location, other than that LGTM 🙂

@MantisClone MantisClone merged commit 3c256d5 into master Oct 16, 2023
27 checks passed
@MantisClone MantisClone deleted the eslint-monorepo-no-relative-import branch October 16, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate relative imports between packages and enforce monorepo/no-relative-import eslint rule
3 participants