Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: core dao #1216

Merged
merged 5 commits into from
Nov 3, 2023
Merged

feat: core dao #1216

merged 5 commits into from
Nov 3, 2023

Conversation

leoslr
Copy link
Contributor

@leoslr leoslr commented Oct 25, 2023 •
edited by MantisClone
Loading

Description of the changes

Supports for CORE chain.

Contract deployed:

All deployed contracts have been verified.

Update contract verification lib.

@leoslr leoslr requested review from MantisClone and removed request for alexandre-abrioux and kevindavee October 25, 2023 16:14
KolevDarko
KolevDarko approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@KolevDarko KolevDarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented Oct 25, 2023 •
edited
Loading

Coverage Status

coverage: 86.925%. remained the same
when pulling 10aae0e on feat/core-support
into cffb965 on master.

MantisClone
MantisClone approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@MantisClone MantisClone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix one minor comment. Looks good 👍

packages/payment-detection/src/eth/multichainExplorerApiProvider.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a block explorer URL to the getBaseUrl() function. Maybe https://scan.coredao.org/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MantisClone I made the update. Not sure the urls are correct for Mantle though. It looks like they're the explorer URLs and not the explorer API URLs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: #1225

@MantisClone MantisClone mentioned this pull request Oct 26, 2023
Closed
3 tasks
@MantisClone MantisClone mentioned this pull request Oct 27, 2023
Merged
@leoslr leoslr merged commit a782146 into master Nov 3, 2023
26 checks passed
@leoslr leoslr deleted the feat/core-support branch November 3, 2023 10:48
@MantisClone MantisClone mentioned this pull request Dec 15, 2023
Closed
5 tasks
@MantisClone MantisClone linked an issue Mar 27, 2024 that may be closed by this pull request
Deploy to CORE #1301
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MantisClone MantisClone MantisClone approved these changes

@KolevDarko KolevDarko KolevDarko approved these changes

@yomarion yomarion yomarion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy to CORE
5 participants
@leoslr @coveralls @KolevDarko @MantisClone @yomarion