fix: zksync networks names to lowercase #1261
Conversation
github-actions
bot
requested review from
alexandre-abrioux,
benjlevesque,
leoslr and
yomarion
KolevDarko
requested review from
AdamREQ and
olivier7delf
and removed request for
yomarion
There was a problem hiding this comment.
@KolevDarko Did you also update the contracts (Batch I think) to modify the nativeHash that was previously used ?
There was a problem hiding this comment.
@KolevDarko @benjlevesque @leoslr I have a couple questions. I just want to make sure the correct addresses are documented in the lib/artifacts/../index.ts files.
| @@ -61,10 +61,14 @@ export const batchPaymentsArtifact = new ContractArtifact<BatchPayments>( | |||
| address: '0x0DD57FFe83a53bCbd657e234B16A3e74fEDb8fBA', | |||
| creationBlockNumber: 35498688, | |||
| }, | |||
| zkSyncEra: { | |||
| zksyncera: { | |||
| address: '0x0C41700ee1B363DB2ebC1a985f65cAf6eC4b1023', | |||
There was a problem hiding this comment.
-
Why is this address identical to the one listed for zkSync Era
BatchConversionPayments -
Why does the zkSync Era explorer show the contract name "BatchConversionPayments" instead of "BatchPayments"?
There was a problem hiding this comment.
The BatchConversionPayments is the contract that is used in production, so that's why that one is deployed.
At the time I thought BatchPayments was the one we were using but if we see the block explorer on mainnet: https://etherscan.io/address/0x0dd57ffe83a53bcbd657e234b16a3e74fedb8fba it hasn't been used for more than a year.
So if you want to clean things up, we can just remove the entries from BatchPayments/index.ts for both prod and test zksync.
| address: '0x0C41700ee1B363DB2ebC1a985f65cAf6eC4b1023', | ||
| creationBlockNumber: 19545614, | ||
| }, | ||
| zksynceratestnet: { | ||
| address: '0x276A92F78aA527b8e157B0E47cEB63b4239dfa0b', |
There was a problem hiding this comment.
Why does the zkSync Era Goerli explorer show the contract name "BatchConversionPayments" instead of "BatchPayments"?
Description of the changes
Following the convention of specifying chain names as lowercase.
Also added the batch contract address from zksync testnet.