Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment-detection): blockFilter should not be empty #1265

Merged
merged 2 commits into from Nov 27, 2023

Conversation

alexandre-abrioux
Copy link
Member

@alexandre-abrioux alexandre-abrioux commented Nov 27, 2023

Description of the changes

This is a fixup for #1262.

TheGraph decentralized gateway does not allow for an undefined blockFilter. It is permitted by TheGraph Nodes, but the gateway itself needs this field to be defined, or else it returns the following:
Invalid query: Failed to determine block constraints.

Instead, we can pass down a block filter targeting all indexers (block_gte: 0).

@alexandre-abrioux alexandre-abrioux enabled auto-merge (squash) November 27, 2023 15:52
@alexandre-abrioux alexandre-abrioux merged commit fc215bf into master Nov 27, 2023
24 of 25 checks passed
@alexandre-abrioux alexandre-abrioux deleted the fix-blockFilter branch November 27, 2023 15:56
@coveralls
Copy link

Coverage Status

coverage: 87.098%. remained the same
when pulling f8673d7 on fix-blockFilter
into 6981bc1 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants