Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: new interface IRequestDataWithEvents #165

Merged
merged 3 commits into from
Mar 13, 2020
Merged

chore: new interface IRequestDataWithEvents #165

merged 3 commits into from
Mar 13, 2020

Conversation

benjlevesque
Copy link
Contributor

Description of the changes

introduce a new interface IRequestDataWithEvents to be able to manipulate IRequestData without having to handle events

@coveralls
Copy link

coveralls commented Mar 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 91.187% when pulling e5a7737 on request-data-with-events into f49640b on master.

vrolland
vrolland approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@vrolland vrolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one

@benjlevesque benjlevesque requested review from rittme and removed request for rittme March 11, 2020 08:16
@benjlevesque benjlevesque merged commit 69a84a5 into master Mar 13, 2020
@benjlevesque benjlevesque deleted the request-data-with-events branch March 13, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rittme rittme rittme approved these changes

@vrolland vrolland vrolland approved these changes

@lumtis lumtis lumtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benjlevesque @coveralls @rittme @vrolland @lumtis