docs: pay with multisig #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
commented
Mar 10, 2020
| @@ -38,8 +38,12 @@ | |||
| "@docusaurus/preset-classic": "2.0.0-alpha.43", | |||
| "@docusaurus/theme-live-codeblock": "2.0.0-alpha.43", | |||
| "@docusaurus/utils": "2.0.0-alpha.43", | |||
| "@requestnetwork/types": "0.12.0", | |||
There was a problem hiding this comment.
@rittme should I include the dependencies I need in the doc here, when using aurelius?
There was a problem hiding this comment.
for now we're not running them, so it will work without. But, yes, long term this is the right approach.
rittme
approved these changes
Mar 11, 2020
| @@ -38,8 +38,12 @@ | |||
| "@docusaurus/preset-classic": "2.0.0-alpha.43", | |||
| "@docusaurus/theme-live-codeblock": "2.0.0-alpha.43", | |||
| "@docusaurus/utils": "2.0.0-alpha.43", | |||
| "@requestnetwork/types": "0.12.0", | |||
There was a problem hiding this comment.
for now we're not running them, so it will work without. But, yes, long term this is the right approach.
yomarion
approved these changes
Mar 11, 2020
Co-Authored-By: Yo <56731761+yomarion@users.noreply.github.com>
yomarion
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Link to Jira
https://requestnetwork.atlassian.net/browse/PROT-