-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: guide documentation for the node #167
Conversation
To launch the Request node you can run: | ||
|
||
```bash | ||
docker run -p 3000:3000 -e MNEMONIC="<your wallet mnemonic>" -e WEB3_PROVIDER_URL="<your web3 provider url>" -e ETHEREUM_NETWORK_ID="<ethereum network id>" -e IPFS_HOST="host.docker.internal" requestnetwork/request-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not reference the internal docker name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not using compose, and setting up a network between them would be more work.
Co-Authored-By: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-Authored-By: Benjamin LEVESQUE <14175665+benjlevesque@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's very obvious but shouldn't we advise on how to test a freshly setup node?
Despite that, everything is super clear!
Description of the changes
Add documentation for the Request Node.