Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guide documentation for the node #167

Merged
merged 3 commits into from
Mar 13, 2020
Merged

docs: guide documentation for the node #167

merged 3 commits into from
Mar 13, 2020

Conversation

rittme
Copy link
Contributor

@rittme rittme commented Mar 11, 2020

Description of the changes

Add documentation for the Request Node.

packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
To launch the Request node you can run:

```bash
docker run -p 3000:3000 -e MNEMONIC="<your wallet mnemonic>" -e WEB3_PROVIDER_URL="<your web3 provider url>" -e ETHEREUM_NETWORK_ID="<ethereum network id>" -e IPFS_HOST="host.docker.internal" requestnetwork/request-node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not reference the internal docker name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not using compose, and setting up a network between them would be more work.

packages/docs/docs/guides/6-hosting-a-node/2-code.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/3-helm.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/2-code.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/2-code.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/2-code.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/3-helm.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/6-hosting-a-node/3-helm.md Outdated Show resolved Hide resolved
Co-Authored-By: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-Authored-By: Benjamin LEVESQUE <14175665+benjlevesque@users.noreply.github.com>
Copy link
Member

@yomarion yomarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's very obvious but shouldn't we advise on how to test a freshly setup node?
Despite that, everything is super clear!

packages/docs/docs/guides/6-hosting-a-node/0-intro.md Outdated Show resolved Hide resolved
@rittme rittme merged commit a7484da into docs-with-sidebar Mar 13, 2020
@rittme rittme deleted the node-docs branch March 13, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants