docs: Adding the introduction to the Request Protocol #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
rittme,
vrolland,
benjlevesque,
AdamREQ and
yomarion
yomarion
reviewed
Mar 13, 2020
vrolland
reviewed
Mar 16, 2020
| To organize these different purposes, the Request Protocol follows the layered architecture pattern. Each layer is responsible for a specific task and a specific level of abstraction. This layered architecture also simplifies the understandability of the code, we believe it's an important matter for an open-source project. | ||
|
|
||
| The protocol is composed of four layers: | ||
| - Request logic |
There was a problem hiding this comment.
As I already stated on Notion, advanced logic is not a layer in the Layered Architecture Pattern point of viewx
We can discuss tomorrow 👍but I think it's already a version pushable, if there are optimization to make we can push them after the doc is released |
yomarion
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Adding the page "Introduction to the Request Protocol" to the documentation