feat: add entry point to request node to get monitoring information #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrolland
changed the title
vrolland
changed the title
vrolland
changed the title
vrolland
requested review from
lumtis,
rittme,
benjlevesque,
AdamREQ and
yomarion
and removed request for
lumtis and
rittme
yomarion
approved these changes
Apr 6, 2020
rittme
reviewed
Apr 7, 2020
packages/data-access/src/transaction-index/transaction-index.ts
Outdated
Show resolved
Hide resolved
lumtis
approved these changes
Apr 7, 2020
AdamREQ
approved these changes
Apr 7, 2020
rittme
approved these changes
Apr 8, 2020
benjlevesque
reviewed
Apr 8, 2020
| import getTransactionsByChannelId from './request/getTransactionsByChannelId'; | ||
| import ipfsAdd from './request/ipfsAdd'; | ||
| import PersistTransaction from './request/persistTransaction'; | ||
| import { getEthereumStorage } from './storageUtils'; | ||
|
|
||
| const NOT_FOUND_MESSAGE = | ||
| 'Not found\nAvailable endpoints:\n/POST persistTransaction\n/GET getTransactionsByChannelId\n/GET getChannelsByTopic\n/POST /ipfsAdd\nGET getConfirmedTransaction'; | ||
| 'Not found\nAvailable endpoints:\n/POST persistTransaction\n/GET getTransactionsByChannelId\n/GET getChannelsByTopic\n/POST /ipfsAdd\nGET getConfirmedTransaction\nGET status'; |
There was a problem hiding this comment.
Suggested change
| 'Not found\nAvailable endpoints:\n/POST persistTransaction\n/GET getTransactionsByChannelId\n/GET getChannelsByTopic\n/POST /ipfsAdd\nGET getConfirmedTransaction\nGET status'; | |
| 'Not found\nAvailable endpoints:\nPOST /persistTransaction\nGET /getTransactionsByChannelId\nGET /getChannelsByTopic\nPOST /ipfsAdd\nGET /getConfirmedTransaction\nGET /status'; |
| const { data } = await Utils.retry( | ||
| async () => | ||
| axios.get( | ||
| '/information', |
There was a problem hiding this comment.
didn't you rename this to /status?
| public getConfig(): any { | ||
| return { | ||
| creationBlockNumberHashStorage: this.creationBlockNumberHashStorage, | ||
| currentProvider: this.eth.currentProvider.host, |
There was a problem hiding this comment.
have you tested if this is infura, the token wouldn't be included?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Add entry point "/status" to get information from the node.