feat(request-node): Add Request Node version and Request Client version to requests header #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rittme
approved these changes
Apr 8, 2020
lumtis
changed the title
lumtis
changed the title
benjlevesque
reviewed
Apr 8, 2020
| it('the response header contains the Request Node version', async () => { | ||
| // Import directly requestNode to create a server | ||
| requestNodeInstance = new requestNode(); | ||
| server = requestNodeInstance.listen(3002, () => 0); |
There was a problem hiding this comment.
you don't have to use listen in unit tests, aren't we using supertest?
vrolland
requested changes
Apr 8, 2020
| @@ -4,6 +4,9 @@ import axios, { AxiosRequestConfig } from 'axios'; | |||
|
|
|||
| import { EventEmitter } from 'events'; | |||
|
|
|||
| const packageJson = require('../package.json'); | |||
| const REQUEST_CLIENT_VERSION_HEADER = 'X-Request-Client-Version'; | |||
There was a problem hiding this comment.
X-Request-Client-Version is this name not too generic?
maybe X-Request-Network-Client-Version to avoid collisions.
It's a genuine question maybe the name is already specific enough.
benjlevesque
approved these changes
Apr 9, 2020
vrolland
approved these changes
Apr 9, 2020
rittme
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Added the Request Node version in the response's header of each request to the Request Node.
Link to Jira
https://requestnetwork.atlassian.net/browse/PROT-1150