Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payment-processor transaction overrides #198

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

benjlevesque
Copy link
Contributor

Description of the changes

Allow overriding transaction parameters, like gasPrice

@benjlevesque benjlevesque requested review from yomarion, rittme, AdamREQ and vrolland and removed request for yomarion April 14, 2020 16:38
Copy link
Contributor

@vrolland vrolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.439% when pulling 89d4003 on payment-tx-overrides into 20ad94b on master.

Copy link
Contributor

@AdamREQ AdamREQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjlevesque benjlevesque merged commit 92a52aa into master Apr 15, 2020
@benjlevesque benjlevesque deleted the payment-tx-overrides branch April 15, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants