Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add signature provider explanation #199

Merged
merged 6 commits into from
Apr 17, 2020
Merged

docs: add signature provider explanation #199

merged 6 commits into from
Apr 17, 2020

Conversation

vrolland
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 14, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 90.353% when pulling 025b3bc on docs-signature-provider into 4d154d7 on master.

benjlevesque
benjlevesque approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@benjlevesque benjlevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after minor modifications

packages/docs/docs/guides/5-request-client/6-signature-provider.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/5-request-client/6-signature-provider.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/5-request-client/6-signature-provider.md Show resolved Hide resolved
packages/docs/docs/guides/5-request-client/6-signature-provider.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/5-request-client/6-signature-provider.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/5-request-client/6-signature-provider.md Outdated Show resolved Hide resolved
vrolland and others added 3 commits April 15, 2020 10:54
@vrolland @yomarion
Update packages/docs/docs/guides/5-request-client/6-signature-provide…
3010d37 
…r.md

Co-Authored-By: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @rittme
@benjlevesque @lumtis
Apply suggestions from code review
e4f5a1b 
Co-Authored-By: Bernardo Rittmeyer <bernardo@rittme.com>
Co-Authored-By: Benjamin LEVESQUE <14175665+benjlevesque@users.noreply.github.com>
Co-Authored-By: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@vrolland
from review
8ff74f6
@vrolland vrolland requested a review from rittme April 17, 2020 10:19
@vrolland vrolland merged commit 37c854a into master Apr 17, 2020
@vrolland vrolland deleted the docs-signature-provider branch April 17, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rittme rittme rittme approved these changes

@lumtis lumtis lumtis approved these changes

@benjlevesque benjlevesque benjlevesque approved these changes

@yomarion yomarion yomarion approved these changes

@AdamREQ AdamREQ Awaiting requested review from AdamREQ

@gawin gawin Awaiting requested review from gawin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vrolland @coveralls @rittme @lumtis @benjlevesque @yomarion