feat: add an option to disable payment detection in the request client #201
Conversation
vrolland
requested review from
rittme,
benjlevesque,
lumtis,
AdamREQ and
yomarion
and removed request for
rittme and
benjlevesque
…estNetwork into get-balance-optional
| @@ -1461,6 +1461,83 @@ describe('index', () => { | |||
| ); | |||
| sinon.restore(); | |||
| }); | |||
|
|
|||
| it('can skip the get the balance of a request', async function(): Promise<void> { | |||
There was a problem hiding this comment.
I would add a check that getBalance was not called. We do this to improve performance, if the balance field is null but getBalance was still called, we didn't achieve much!
There was a problem hiding this comment.
I don't know how to test expecting putting private paymentNetwork: PaymentTypes.IPaymentNetwork | null = null; to public in the request class.
@rittme what do you think ?
There was a problem hiding this comment.
after rethinking it, We return the previous balance to avoid loosing information
There was a problem hiding this comment.
I don't understand. Can't you add a spy to getBalance and make sure it's not called?
There was a problem hiding this comment.
the payment network is nested in the class as private.
There was a problem hiding this comment.
private stuff sucks because of this :/ If we're sure we're not calling getBalance, I'm fine with leaving like this for now.
There was a problem hiding this comment.
Can't you solve this with any ?
| @@ -1461,6 +1461,83 @@ describe('index', () => { | |||
| ); | |||
| sinon.restore(); | |||
| }); | |||
|
|
|||
| it('can skip the get the balance of a request', async function(): Promise<void> { | |||
There was a problem hiding this comment.
I don't understand. Can't you add a spy to getBalance and make sure it's not called?
No description provided.