Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enhance node synchronization and storing of ignored data #205

Merged
merged 11 commits into from
Apr 23, 2020
Merged

fix: enhance node synchronization and storing of ignored data #205

merged 11 commits into from
Apr 23, 2020

Conversation

vrolland
Copy link
Contributor

@vrolland vrolland commented Apr 22, 2020 •
edited
Loading

Description

  • Store the ignored data only at the end of the synchronization
  • Store more information on the ignored data to prepare the next step
  • Add more tests
  • Split a big function in two

Next step

A mechanism to retrieved previous ignored data through time

@coveralls
Copy link

coveralls commented Apr 22, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 90.147% when pulling 9f951fd on ethereum-storage-better-ignored-storing into 8bafd15 on master.

@vrolland vrolland changed the title fix: enhance node syncronization and ignored data storing fix: enhance node syncronization and storing of ignored data Apr 22, 2020
benjlevesque
benjlevesque reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@benjlevesque benjlevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind the typo in the commit :)

could you explain how this will behave? I mean, will it slow down the initialization or retry at a later point in time. Also, does this require clearing existing index files?

packages/types/src/storage-types.ts Outdated Show resolved Hide resolved
packages/types/src/storage-types.ts Outdated Show resolved Hide resolved
packages/types/src/storage-types.ts Outdated Show resolved Hide resolved
packages/ethereum-storage/src/ethereum-storage.ts Outdated Show resolved Hide resolved
packages/ethereum-storage/test/synhronization.test.ts Outdated Show resolved Hide resolved
@vrolland
Copy link
Contributor Author

mind the typo in the commit :)

could you explain how this will behave? I mean, will it slow down the initialization or retry at a later point in time. Also, does this require clearing existing index files?

  1. The behavior remains the same. It just fix the storing of ignored data. (the retry through time will be added in another PR)
  2. As the name of the ignored dataId storing has changed, probably not.

@vrolland vrolland changed the title fix: enhance node syncronization and storing of ignored data fix: enhance node synchronization and storing of ignored data Apr 23, 2020
vrolland and others added 3 commits April 23, 2020 11:54
@vrolland @rittme
Update packages/ethereum-storage/src/ignored-dataIds.ts
dcd848e 
Co-Authored-By: Bernardo Rittmeyer <bernardo@rittme.com>
@vrolland
from BRI review
e348eb2
@vrolland
Merge branch 'ethereum-storage-better-ignored-storing' of github.com:…
9f951fd 
…RequestNetwork/requestNetwork into ethereum-storage-better-ignored-storing
@vrolland vrolland merged commit fb6add2 into master Apr 23, 2020
@vrolland vrolland deleted the ethereum-storage-better-ignored-storing branch April 23, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rittme rittme rittme approved these changes

@benjlevesque benjlevesque benjlevesque approved these changes

@AdamREQ AdamREQ Awaiting requested review from AdamREQ

@lumtis lumtis Awaiting requested review from lumtis

@yomarion yomarion Awaiting requested review from yomarion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vrolland @coveralls @rittme @benjlevesque