Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: payment network any to erc20 in advanced logic #414

Merged
merged 48 commits into from
Feb 25, 2021
Merged

feat: payment network any to erc20 in advanced logic #414

merged 48 commits into from
Feb 25, 2021

Conversation

vrolland
Copy link
Contributor

Description of the changes

add tthe payment network any to erc20 to the advanced logic

vrolland and others added 29 commits February 12, 2021 14:47
@vrolland
docs: specification for the payment network any to erc20
4ac7d6d
@vrolland
from LBE review
114f6a0
@vrolland
fix
ac228bc
@vrolland
add smarcontracts for any to erc20 proxy
00dd827
@vrolland
add tools for the currency
6e1b4c0
@vrolland
update address in specs
791888b
@vrolland
Merge branch 'master' into pn-any-to-erc20-smartcontracts
d3a61da
@vrolland
fix lint
2e492d7
@vrolland
Merge branch 'pn-any-to-erc20-smartcontracts' of github.com:RequestNe…
31d642c 
…twork/requestNetwork into pn-any-to-erc20-smartcontracts
@vrolland
fix test
87afe90
@vrolland
from BLE review
b012020
@vrolland
fix
577fc28
@vrolland @yomarion
Update packages/currency/src/chainlink-path-aggregators.ts
4841635 
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/currency/test/chainlink-path-aggregators.test.ts
ffc04c6 
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
0235f53 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
b43277d 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
7f9e248 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
447736b 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
abaf93a 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
2aff97d 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/smart-contracts/src/contracts/ChainlinkConversionPath…
4200cc4 
….sol

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland
from YMA review
c90cf07
@vrolland
Merge branch 'pn-any-to-erc20-smartcontracts' of github.com:RequestNe…
c9d5469 
…twork/requestNetwork into pn-any-to-erc20-smartcontracts
@vrolland
fix lint
d0d4c06
@vrolland
remove unecessary test
8b682fc
@vrolland
update comment
14629cb
@vrolland
feat: payment network any to erc20 in advanced logic
760cd4e
@vrolland
fix lint
646d6b5
@vrolland
Merge branch 'master' into pn-any-to-erc20-adv-logic
a55c85d
@coveralls
Copy link

coveralls commented Feb 18, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.433% when pulling b595865 on pn-any-to-erc20-adv-logic into c6e34ed on master.

yomarion
yomarion requested changes Feb 24, 2021
View reviewed changes
Copy link
Member

@yomarion yomarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there, awesome !
Please clean a few things before pushing.

packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Outdated Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Outdated Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Outdated Show resolved Hide resolved
packages/advanced-logic/src/extensions/payment-network/any-to-erc20-proxy.ts Outdated Show resolved Hide resolved
packages/types/src/payment-types.ts Outdated Show resolved Hide resolved
packages/types/src/payment-types.ts Outdated Show resolved Hide resolved
vrolland and others added 4 commits February 25, 2021 09:26
@vrolland @yomarion
Update packages/advanced-logic/src/extensions/payment-network/any-to-…
3235cc9 
…erc20-proxy.ts

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Apply suggestions from code review
3b8013f 
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/advanced-logic/src/extensions/payment-network/any-to-…
a4e81cb 
…erc20-proxy.ts

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/advanced-logic/src/extensions/payment-network/any-to-…
03cdcf9 
…erc20-proxy.ts

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
vrolland and others added 3 commits February 25, 2021 09:48
@vrolland @yomarion
Update packages/advanced-logic/src/extensions/payment-network/any-to-…
4ce39b8 
…erc20-proxy.ts

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland @yomarion
Update packages/advanced-logic/src/extensions/payment-network/any-to-…
25fa07b 
…erc20-proxy.ts

Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
@vrolland
fix test
d6fe949
GrandGarcon
GrandGarcon approved these changes Feb 25, 2021
View reviewed changes
Copy link

@GrandGarcon GrandGarcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good PR to review coz it gave needed insights to the addition of new stadard types ( whether tokens or blockchains ). thanks

yomarion
yomarion approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@yomarion yomarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@vrolland vrolland merged commit 45f09f9 into master Feb 25, 2021
@vrolland vrolland deleted the pn-any-to-erc20-adv-logic branch February 25, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjlevesque benjlevesque benjlevesque approved these changes

@AdamREQ AdamREQ AdamREQ approved these changes

@GrandGarcon GrandGarcon GrandGarcon approved these changes

@yomarion yomarion yomarion approved these changes

@siibars siibars Awaiting requested review from siibars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vrolland @coveralls @benjlevesque @AdamREQ @GrandGarcon @yomarion