fix: change note type to string

[kevindavee]

Description of the changes

note should be type string. Changing the test and the Typescript type.

[coveralls]

Coverage remained the same at 88.829% when pulling 99ff596 on fix/note-type into 20dfa5a on master.

[yomarion]

I don't really understand why note would not be string anymore, it's specified as a string.

[kevindavee]

Based on the test, it looks like note accepts anything.

requestNetwork/packages/advanced-logic/test/utils/payment-network/any/generator-data-create.ts

Line 12 in 7c7e64e

export const note = { transactionId: '123456789' };

I'm not sure which is the source of truth but this test has been there for 3 years based on the git commit @yomarion

[vrolland]

I think any is better because declarative's actions are now very generic.
Only string is too restrictive. For example in our case of manual payment declaration on a crypto request:

{ transactionHash: '0x12345' }

is more explicit than only "0x12345".

[vrolland]

I don't really understand why note would not be string anymore, it's specified as a string.

@yomarion @kevindavee
note is a string in the request-client.js and any in advanced-logic.
I think we should modify the request-clients.js to be more generic and reflect the change we made in advanced logic.

[yomarion]

I don't really understand why note would not be string anymore, it's specified as a string.

@yomarion @kevindavee note is a string in the request-client.js and any in advanced-logic. I think we should modify the request-clients.js to be more generic and reflect the change we made in advanced logic.

It's defined here as a string. What is it if it's not a string? It should be defined clearly before changing the whole implementation.

[kevindavee]

I don't know the historical why there's a discrepancy between the types in advance-logic and request-client.js. But, in my opinion, note sounds like a string instead of any.

[kevindavee]

@vrolland can you review this PR again as we have reached a consensus to have note as string?