Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xdai rpc provider #637

Merged
merged 2 commits into from
Oct 18, 2021
Merged

feat: add xdai rpc provider #637

merged 2 commits into from
Oct 18, 2021

Conversation

KolevDarko
Copy link
Contributor

Description of the changes

Copy link
Contributor

@AdamREQ AdamREQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering but why do BSC/xDai have a trailing slash and the others don't?

@KolevDarko
Copy link
Contributor Author

Hey @adamdowson it's not on purpose, but I see it's also like that on fatom, I don't think it makes a difference because we're not appending extra url routes to the rpc url

@KolevDarko KolevDarko enabled auto-merge (squash) October 18, 2021 07:41
@KolevDarko KolevDarko merged commit fc24e5e into master Oct 18, 2021
@KolevDarko KolevDarko deleted the feat/add-xdai-rpc-provider branch October 18, 2021 07:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.944% when pulling 5878603 on feat/add-xdai-rpc-provider into 799680f on master.

kevindavee added a commit that referenced this pull request Oct 21, 2021
fix: test

chore: added auto_assign file (#631)

chore: auto_assign as a worfklow (#633)

feat: added xdai to fee-proxy-contract networks (#636)

fix: proxy contract test

feat: inherit declarative on ETH input and fee proxy

feat: add xdai rpc provider (#637)

test: remove declarative test as ETH input data support declarative

chore(request-node): add transaction hash debug log (#638)

chore: deploy on live chains (#550)

Co-authored-by: Benjamin Levesque <14175665+benjlevesque@users.noreply.github.com>

chore: test verified commit
kevindavee added a commit that referenced this pull request Oct 21, 2021
fix: test

chore: added auto_assign file (#631)

chore: auto_assign as a worfklow (#633)

feat: added xdai to fee-proxy-contract networks (#636)

fix: proxy contract test

feat: inherit declarative on ETH input and fee proxy

feat: add xdai rpc provider (#637)

test: remove declarative test as ETH input data support declarative

chore(request-node): add transaction hash debug log (#638)

chore: deploy on live chains (#550)

Co-authored-by: Benjamin Levesque <14175665+benjlevesque@users.noreply.github.com>

chore: test verified commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants