-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xdai rpc provider #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamREQ
approved these changes
Oct 15, 2021
AdamREQ
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering but why do BSC/xDai have a trailing slash and the others don't?
bertux
approved these changes
Oct 15, 2021
Hey @adamdowson it's not on purpose, but I see it's also like that on fatom, I don't think it makes a difference because we're not appending extra url routes to the rpc url |
kevindavee
added a commit
that referenced
this pull request
Oct 21, 2021
fix: test chore: added auto_assign file (#631) chore: auto_assign as a worfklow (#633) feat: added xdai to fee-proxy-contract networks (#636) fix: proxy contract test feat: inherit declarative on ETH input and fee proxy feat: add xdai rpc provider (#637) test: remove declarative test as ETH input data support declarative chore(request-node): add transaction hash debug log (#638) chore: deploy on live chains (#550) Co-authored-by: Benjamin Levesque <14175665+benjlevesque@users.noreply.github.com> chore: test verified commit
kevindavee
added a commit
that referenced
this pull request
Oct 21, 2021
fix: test chore: added auto_assign file (#631) chore: auto_assign as a worfklow (#633) feat: added xdai to fee-proxy-contract networks (#636) fix: proxy contract test feat: inherit declarative on ETH input and fee proxy feat: add xdai rpc provider (#637) test: remove declarative test as ETH input data support declarative chore(request-node): add transaction hash debug log (#638) chore: deploy on live chains (#550) Co-authored-by: Benjamin Levesque <14175665+benjlevesque@users.noreply.github.com> chore: test verified commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes