chore(request-node): remove dockerfile #767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR is a proposal to remove the
Dockerfile
from therequest-node
package as it could bring some confusion (explanation bellow).1/ Prod Releases
The
Dockerfile
is not used for production releases anymore since this responsibility was migrated to the RequestNetwork/docker-images repository.2/ Pre Releases
Pre-production releases are now also handled by the RequestNetwork/docker-images repository.
3/ Dev Builds
The
Dockerfile
was still useful for development builds.The main issue is that, when internal dependencies are modified locally, for instance
@requestnetwork/ethereum-storage
, the lineRUN npm install
would still pick the latest release of those packages on NPM instead of locally changed ones.That is why a
Dockerfile.dev
now exists in the package to take care of this use case.Overall it looks to me like this
Dockerfile
is not needed anymore and can bring some confusion to new contributors.