chore(smart-contracts): rename dockerfile to dockerfile.dev #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benjlevesque,
bertux,
kevindavee and
yomarion
benjlevesque
approved these changes
Feb 9, 2022
KolevDarko
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This is a proposal to rename
Dockerfilefrom thesmart-contractspackage toDockerfile.devin order to align with the naming convention used in other packages likerequest-node.In fact, this
Dockerfileis not used for releases on the DockerHub anymore, as this responsibility was moved to the RequestNetwork/docker-images repository. It is only used for development purposes as of today, in order to test local changes made to the package.