feat: retrieve active escrow data #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
bertux,
kevindavee and
yomarion
alexandre-abrioux
approved these changes
Mar 30, 2022
kevindavee
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ads a method for reading data from the Escrow smart contract directly to the EscrowInfoRetriever.
We need to read data from a mapping in the Escrow contract to be able to figure out some deadlines when freezing funds etc.
This data is not broadcasted in any events so the only way to get it is from the contract directly.
This new function is exposed to 3rd party users via request-client.js, within the Request class.